feat: Implement rtransaction builder#34
Merged
wheval merged 3 commits intoancore-org:mainfrom Feb 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Add Transaction Builder with Stellar SDK v13 Support
Description
This PR implements a new
AccountTransactionBuilderclass that provides a fluent API for building and submitting Stellar transactions using the updated Stellar SDK v13. The builder pattern simplifies transaction creation and ensures proper operation handling.Closes #19
Key Changes:
AccountTransactionBuilderclass with fluent API for transaction constructionrpcimport from@stellar/stellar-sdkv13 (replacing deprecatedSorobanRpc)Features:
Type of Change
Security Impact
The transaction builder provides a convenience layer but does not modify core security logic. All cryptographic operations are handled by the underlying Stellar SDK.
Testing
Test Coverage
Manual Testing Steps
Breaking Changes
No breaking changes. This is a new feature addition that doesn't affect existing code.
Checklist
For High-Security Changes
N/A - This is not a high-security change.
Related Issues
Part of the Ancore SDK development roadmap.
Implements transaction building utilities for account abstraction layer.
Additional Context
Implementation Details
The
AccountTransactionBuilderprovides:Files Modified
packages/core-sdk/src/account-transaction-builder.ts- New transaction builder implementationpackages/core-sdk/src/__tests__/builder.test.ts- Unit tests for builderpackages/core-sdk/src/__tests__/integration.test.ts- Integration testsSDK Migration Notes
This PR uses the new
rpcnamespace from@stellar/stellar-sdkv13:SorobanRpc→rpc.ServerReviewer Notes
Focus Areas:
Testing Priority:
The integration tests demonstrate real transaction submission to testnet. Please verify they pass in your environment.
Questions for Review: